Repository navigation
Scopes - #118
Merged
Merged
Scopes#118
Conversation
TylerLeonhardt
requested review from
TylerLeonhardt,
Øyvind Kallstad (gravejester) and
sergei (vors)
June 9, 2018 18:55
sergei (vors)
approved these changes
Jun 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$is now scopedpunctuation.definition.variable.powershellwhich is correct but also has the same scope as the variable itself. In themes that definepunctuation.definition.variableit will use those colours but in themes that do not it will be the same colour as the variable. This fixes Dollar sign '$' should be included as part of the variable token #23.The
;has been rescoped. This fixes ";" scope goes against guidelines #114.The
'and"characters that open and close strings have been rescoped. This fixes single quoted strings missing punctuation scopes #110.Per Chained methods and properties on expressions #107 variable members have been rescoped. Issue still requires work.
Everything following
--%has been rescoped. This fixes stop-parsing symbol doesn't stop PowerShell highlighting #113.