Skip to content

".role" in a comment does not highlight correctly #119

Closed

Description

Environment

  • Editor and Version (VS Code, Atom, Sublime): VSCode, 1.25.0-insiders (Commit: 7dc9539a421c9c33e57e2ce0b718f183bb44c756)
  • Your primary theme: DefaultDark (issue occurs in all themes)

Issue Description

If a comment string contains .Role or .role, the word "role" is colored incorrectly.

Screenshots

image

Expected Behavior

.role/.Role should remain green/the color of the comments.

Code Samples

# This role works
# This .Role doesn't work
# This .role doesn't work
# $MachineParts.RoleCode

Activity

  1. omniomi commented on Jun 15, 2018

    @omniomi
    Contributor

    Looks like we missed a negative lookbehind for words in front of comment.documentation.embedded.powershell within the commentEmbeddedDocs repository section. The match should insure nothing but white space or the # symbol between the beginning of the line and the ..

    Good catch, will fix; Thanks.

  2. added a commit that references this issue on Jun 18, 2018
    6d8d7e7
  3. added a commit that references this issue on Jun 19, 2018
    146e421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions