numeric file size modifier scope #111

Activity

1. Nick James (omniomi)

   added

   scope-change

   on May 31, 2018
2. msftrncs commented on May 15, 2019

   

   Carl Morris (msftrncs)

   on May 15, 2019

   Contributor

   More actions

   Keith Hall (@keith-hall), I am not sure that storage.type is a great scope. Numbers already support a storage type modifier, so that would clash.

   1Dkb
   1.Dkb
   1.E12kb
   1.1Dkb
   1.1E12kb
   .1E+12Dkb
   1Lkb
   1.5Lpb
   1.E12Lkb
   1.14E12Lkb
   .14Ltb
   1E12Lkb

   (note some of these fail to scope correctly in the current grammar)

   In the current grammar, the D (for [decimal]) and the L (for [long]) are not separated from the number, but they are technically the storage type modifier. In PR #156 I have assigned them storage.modifier and have assigned the byte scale as constant.langauge

   In a modified VS Code Monokai Dimmed this gives: (with keyword and constant comparison)

   

   I suppose a possibility is that the byte scale could be a form of operator (its providing multiplication), but in a lot of themes, keyword.other and keyword.operator are the same.

   👍React with 👍1Reacted by Keith Hall
3. keith-hall commented on May 17, 2019

   

   Keith Hall (keith-hall)

   on May 17, 2019

   ContributorAuthor

   More actions

   good point about color schemes, your solution works for me, thanks Carl Morris (@msftrncs) :)