Repository navigation
non-orthodox numbers highlighting #103
Description
Environment
- Editor and Version (VS Code, Atom, Sublime): Sublime
- Your primary theme: Default (Monokai??)
Issue Description
This is all valid numbers in ps
1.21e+3l
1.21E-3d
2.12e3lmb
3.1415e3lgb
3.1415e3lkbScreenshots
Expected Behavior
Consistency (this is current ST grammar)
Activity
[-]$_ is inconsistent with $a[/-][+]non-orthodox numbers highlighting[/+]omniomi commentedon May 26, 2018
Looks like I missed some cases when I looked at numeric constants. I'll take another pass.
msftrncs commentedon May 15, 2019
Some more examples,
I think there are a couple more scenario's included here, such as decimal numbers without a leading digit before the decimal point.
I have these worked out in PR #156, I merged the regex in to 3 primary patterns, integer, hex, and decimal, but did not scope them by their final storage type. I have eliminated the patterns that are not allowed (they haven't implemented binary or allowing underscore separators). I could separate these changes out to a new PR.