Repository navigation
adjustCheckpoints after mint or burn #517
Description
In SecurityToken.sol line 504 (adjusts totalSupply at checkpoint AFTER minting or burning tokens) but it is called on lines 683 and 726 BEFORE change totalSupply_
For example,
checkpoint = 0
checkpoint value = 0
total supply = 0
Somebody buy 100 tokens. checkpoint value = 0, total supply = 100
Somebody buy 200 tokens. checkpoint value = 100, total supply = 300
We create a new checkpoin. Remember, total supply is 300 now!!!
checkpoint = 1
checkpoint value = 100
total supply = 300
Somebody buy 300 tokens. checkpoint value = 300, total supply = 600
We want to see total supply at checkpoint 0. It returns 100, but should return 300.
Activity
maxsam4 commentedon Jan 14, 2019
@AlexejShevchenko Thanks for trying out our Security token!
I just tried playing with checkpoints and they seemed to be functioning fine. There are two things that might have went wrong with your test:
If you think none of the above caused this Issue, please share the address of your security token and I'll look into what went wrong. If you used a private network then maybe share the script or exact steps you took? Thanks!
AlexejShevchenko commentedon Jan 14, 2019
I'm not testing token yet, I'm just read a code of contracts.
Line 502
As I understand, this function should be called AFTER totalSupply changes
But it is called on lines 683 and 726 BEFORE change totalSupply_
maxsam4 commentedon Jan 14, 2019
@AlexejShevchenko
adjustTotalSupplyCheckpoints()is used to update last created checkpoint (if it hasn't been updated yet). Hence, It is called before updatingtotalSupply.When a checkpoint is created, total supply and balances are not snapshotted instantly. They are stored in the next transaction and hence they need to be stored before the total supply is updated by that transaction. We'll update the code comment to reflect this. Thanks for pointing this out!
adamdossa commentedon Jan 14, 2019
Thanks @AlexejShevchenko for reviewing this. We have fixed the comments in 2.1 version of the code!
#519