Skip to content

Eternal Storage missing public functions #484

Closed

Description

@maxsam4

In the eternal storage contract, There are public functions for getting Elementary Data Type variables like uint but the functions to get Arrays are marked internal. Those functions can also be useful to outside world and should be marked public.

functions like

function getArrayAddress(bytes32 _key) internal view returns(address[]) {
        return addressArrayStorage[_key];
}

should become

function getArrayAddress(bytes32 _key) public view returns(address[]) {
        return addressArrayStorage[_key];
}

Activity

  1. dev1644 commented on Dec 20, 2018

    @dev1644
    Contributor

    I am working on it.

  2. added a commit that references this issue on Dec 21, 2018
  3. maxsam4 commented on Dec 22, 2018

    @maxsam4
    ContributorAuthor

    Closed by #488
    Thank you @dev1644 for your contribution.

  4. added a commit that references this issue on Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions