Skip to content

Convert hexadecimal file to decimal & feature extraction - #32

Merged
conorato merged 32 commits into
masterfrom
backend/classification
Oct 22, 2020
Merged

conorato merged 32 commits into
masterfrom
backend/classification

Conversation

@conorato

@conorato conorato commented Oct 8, 2020 •

Copy link
Copy Markdown
Contributor

Summary

This PR includes work to

  • Receive SD card file and converts it to a signed decimal array
  • Validates data
  • Extracts features from data provided in the file

@conorato

conorato commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

rename backend package to classification

@conorato
conorato marked this pull request as ready for review October 18, 2020 05:48
@conorato conorato changed the title [WIP] Backend/classification Convert hexadecimal file to decimal & feature extraction Oct 18, 2020
@conorato

Copy link
Copy Markdown
Contributor Author

@abelfodil abelfodil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall big brain stuff

Juste quelques commentaires sur la forme, sinon ça me semble correct

Comment thread backend/app.py Resolved
Comment thread backend/requirements.txt Resolved
Comment thread backend/requirements.txt Resolved
Comment thread backend/requirements.txt Resolved
Comment thread backend/classification/validation.py Resolved
Comment thread backend/classification/validation.py Resolved
Comment thread backend/classification/predict.py Resolved
@conorato
conorato requested a review from abelfodil October 19, 2020 03:42

@abelfodil abelfodil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sinon lgtm

Comment thread backend/app.py Resolved
@conorato
conorato requested a review from abelfodil October 19, 2020 20:12
Comment thread backend/app.py Resolved
@conorato
conorato requested a review from abelfodil October 20, 2020 03:15

@WilliamHarvey97 WilliamHarvey97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Ça avance bien. Il ne manque plus qu'un dernier allez-retour au notebook et cela devrait être bon.

Comment thread backend/app.py Resolved
Comment thread backend/classification/exceptions.py Resolved
Comment thread backend/classification/exceptions.py Resolved
Comment thread backend/classification/file_loading.py Resolved
Comment thread backend/classification/file_loading.py Resolved
Comment thread backend/app.py Resolved
@conorato
conorato merged commit b2b8792 into master Oct 22, 2020
@conorato
conorato deleted the backend/classification branch October 22, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants