You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
HUGE off-heap memory leak and heap memory leak when using quick-js #61
changed the title [-]HUGE off-heap memory leak and heap memory leak when using quick-js[/-][+]HUGE off-heap memory leak and heap memory leak when using 2.x version[/+]on Feb 17, 2022
changed the title [-]HUGE off-heap memory leak and heap memory leak when using 2.x version[/-][+]HUGE off-heap memory leak and heap memory leak when using quick-js[/+]on Feb 17, 2022
@sandtechnology I don't know a whole lot of c++ but I saw there is a fork of quack that seems better maintained. If you understand it, can you check this fork to see if it looks like it fixes the problem? https://github.com/uk-taniyama/quack
I just implemented another possible engine to use called RhinoJS. I'm not entirely sure what all it offers but I tested basic script evaluations which seemed to work fine. I have a copy of the jar in this open PR #65
Activity
sandtechnology commentedon Feb 17, 2022
And seems is the bug from quack which introduced by Javascript-Expansion 2.x, so I will try to use 1.x to see if it fixed it.
[-]HUGE off-heap memory leak and heap memory leak when using quick-js[/-][+]HUGE off-heap memory leak and heap memory leak when using 2.x version[/+][-]HUGE off-heap memory leak and heap memory leak when using 2.x version[/-][+]HUGE off-heap memory leak and heap memory leak when using quick-js[/+]partydev commentedon Jun 3, 2022
Confirmed this with our testing. We were leaking 650mb/s at one point. Removing QuickJS solved it. We never had a heap memory leak, only native.
darbyjack commentedon Jun 3, 2022
@sandtechnology I don't know a whole lot of c++ but I saw there is a fork of quack that seems better maintained. If you understand it, can you check this fork to see if it looks like it fixes the problem? https://github.com/uk-taniyama/quack
darbyjack commentedon Jun 3, 2022
I just implemented another possible engine to use called RhinoJS. I'm not entirely sure what all it offers but I tested basic script evaluations which seemed to work fine. I have a copy of the jar in this open PR #65