Skip to content

Build to ES5 #8

Open
Open

Description

@nattelog

The current npm package isn't built to ES5, only ES6. Is there a reason for it? Or is it possible to compile the code before publishing it?

Activity

  1. Philmod commented on Aug 4, 2016

    @Philmod
    Owner

    Hey Natanael,

    Could you tell me more about the reason you need the ES5 version? In which environment are you using this package?

  2. nattelog commented on Aug 5, 2016

    @nattelog
    Author

    Hi,

    In my device model I use velocity model which use your PID controller. I use the device model on a website so the ES6 pid controller code runs there. It works on Chrome but not on Safari. I could build it myself but I thought it would be better if it was already built when I require it.

  3. Philmod commented on Aug 5, 2016

    @Philmod
    Owner

    If you use browserify, you should be able to compile it in the format you need. Would that help?

  4. nattelog commented on Aug 9, 2016

    @nattelog
    Author

    Well, my project use webpack. Perhaps it has a solution for it. Thanks for the help anyway! 😄

  5. Philmod commented on Aug 9, 2016

    @Philmod
    Owner

    You have to use a compiler like Babel, that will work with webpack.

  6. rreusser commented on Aug 18, 2016

    @rreusser

    I've submitted a PR (#9) to accomplish this without duplicating files, either in the source or in the npm module. It's opinionated so you're 100% free to just disregard! For me though, I was just making a medium-sized browser-targeted demo that didn't really benefit at all from ES6, so it was just a bit unpleasant to babelify the whole project for one dependency (requires working browserify into the dev server and build step, which isn't that bad, but a slight pain). Either way though, thanks for the great module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions