Skip to content

Directory view toggle icon is wrong. #213

Open

Description

@dinukadesilva

image

image

Activity

  1. xinan commented on Dec 31, 2015

    @xinan
    Member

    What do you mean by wrong? I guess this is subject 😅 If you percept it as the current display mode, it is correct. If you perceive it as an action button, it is wrong.

    If i remember correctly, this behaves just like the similar switch in Windows Explorer, which displays the current display mode, instead of the mode that it would trigger. Personally I think this is more intuitive. But ideas are welcome 😊

  2. dinukadesilva commented on Dec 31, 2015

    @dinukadesilva
    ContributorAuthor

    ah............If that is the case, it's correct

    But, I felt like it's a switch since it's a button.

  3. dinukadesilva commented on Dec 31, 2015

    @dinukadesilva
    ContributorAuthor

    Don't you feel like it's better if it's a switch. I mean.............

    In windows explorer, it has a drop down, and showing the selected mode.

    But, if you check in google drive or gmail, the same implementation is there as a switch. And also, when it's a button, I think it should show what's it's action more than it's status.
    😊

  4. xinan commented on Jan 13, 2016

    @xinan
    Member

    Hmm, now both way seems fine to me 😳

    I guess the reason why I would consider it as status is because this button does not has borders. When you hover on it, it does not show borders to indicate that it is an action, whereas Google Drive does that.

    Let's see what @davidbau thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions