Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
With 3.29 Path of Exile changed all socket colors to be by default white and no longer reliant on the base requirements.
PoB still creates items on e.g. INT bases with 6 blue sockets however.
With this PR all newly created items have per default only white sockets. They can still be manually adjusted of course in the item editor.
PoB has also introduced in 3.29 a button on the socket groups when the skill group is socketed in to an item to allow optimization of the socket colors to provide the correct colors for all gems to get the +10% quality on all sockets. This is however not really realistic and is highly dependent on socket amount and base attribute requirements. Additionally there is currently no way of quickly removing the socket color optimization besides editing the item directly (need to switch tab, find item, edit colors, save, ...).
This PR takes the existing socket color editor from the item editor and adds it to the Socket Group in replacement of the old Color/Link view to allow easy manual editing of socket colors without leaving the Skills tab. Abyss sockets remain unmodifyable.
The Optimize Sockets button functionality has been retained and still works as before (I just renamed it to be a bit more clear on what it does).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/fiDdQ8xyLph
Before screenshot:
Socket Group Editing:

New Item previously all red on STR base:

After screenshot:
New Item all White:
