Skip to content

"Trade for items" feature (one handed weapon) doesn't take into account "1% increased damage per 15 strength" mod on amulet #5438

Closed as not planned

Description

@melink14

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

How is Path of Building expected to behave?

In general, it seems that the generated mod weights take into account global state of my character so I would also expect it to know that strength gives me increased damage.

How does Path of Building behave?

The list of generated weights is missing strength as a damage mod despite it being enough to change the order of the results when sorting by weighted sum.

How to reproduce the issue

  1. Import build
  2. Trade for new sceptre.
  3. Notice that weapons with strength are not sorted as highly as they should.

Results might not be the same but here's example showing no strength in search (https://www.pathofexile.com/trade/search/Sanctum/r7kMQjZiQ). See screenshot for example where order was wrong due to it not being taken into account.

Character build code

https://pobb.in/p7LqLc8hGAo6

Screenshots

image

Activity

  1. QuickStick123 commented on Dec 23, 2022

    @QuickStick123
    Contributor

    This is impossible to fix sorry we have run out of mods we can search for otherwise we hit search complexity limit. For example the int gem mod gives around 0.7% and 55 strength roll would be about 0.6%. Everything else would obviously give more.
    image
    image
    Some synth mods seem to be leaking in even when it is turned off which should be fixed in an upcoming patch but there isn't really anything we can do here.

  2. added
    wontfixThis will not be worked on
    and removed
    bugSomething isn't working
    on Dec 23, 2022
  3. melink14 commented on Dec 23, 2022

    @melink14
    Author

    Seems fair. I was just surprised when the lower ranked item gave more damage in PoB.

    To the complexity point, there are several higher weighted irrelevant mods which I have to manually remove now that could make room for a more complete list but priority shouldn't be high for such marginal gains.

  4. QuickStick123 commented on Dec 23, 2022

    @QuickStick123
    Contributor

    There is a sorting option (basically re-ranks items based upon testing their impact on your build not item weight) here that should fix that. There is currently a bug with that search option not using full dps but it will be the default and be fixed in #5375
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    wontfixThis will not be worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions