Skip to content

chore(deps): bump google.golang.org/grpc from 1.84.0 to 1.85.0 - #122

Merged
ImMohammad20000 merged 1 commit into
devfrom
dependabot/go_modules/dev/google.golang.org/grpc-1.85.0
Nov 2, 2026
Merged

chore(deps): bump google.golang.org/grpc from 1.84.0 to 1.85.0#122
ImMohammad20000 merged 1 commit into
devfrom
dependabot/go_modules/dev/google.golang.org/grpc-1.85.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps google.golang.org/grpc from 1.84.0 to 1.85.0.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.85.0

New Features

  • stats: Expose the effective client authority (sent on the wire as the HTTP/2 :authority header) in client stats.OutHeader events. (#9296)
  • metadata: Add ValueFromOutgoingContext, which reads a single metadata value from outgoing context without copying the entire outgoing metadata into a new map. (#9282)

Bug Fixes

  • transport: Refine control buffer throttling to only count peer-induced control frames, raise the default GRPC_GO_EXPERIMENTAL_CONTROL_BUFFER_THROTTLE_LIMIT from 100 to 10,000, and close client connections if reads remain throttled for 10s. (#9563)
  • server: Ensure Stop() forcefully terminates the server while GracefulStop() is waiting for active handlers to complete. (#9394)
  • server: Unconditionally increment the highest-seen stream ID on when handling HEADERS frames to comply with RFC 7540 §5.1.1. Previously, truncated HEADERS frames left the connection in an inconsistent state and allowed stream IDs to be reused by clients without resulting in a protocol error. (#9414)
  • server: Terminate streams immediately when a HEADERS frame includes the EndStream bit. Previously, this caused server handlers to hang when reading a message. (#9391)
  • server: Reject requests missing both :authority and Host headers with HTTP 400 and status Internal. (#9365)
  • xds: Fix a bug where route header matchers with non-lowercase names failed to match routes. (#9353)
  • client: Ensure retried RPCs use the correct :authority value specified by the LB policy instead of inheriting it from a previous attempt. (#9277)
  • transport: Fail streams with io.ErrUnexpectedEOF instead of io.EOF upon receiving truncated message headers or bodies after partial data has already been received. (#9204)
Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ea8c82dd-a319-4a75-bab2-7871df274a17

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ImMohammad20000

ImMohammad20000 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is already up-to-date with dev! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@ImMohammad20000

ImMohammad20000 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@dependabot recreate

@dependabot
chore(deps): bump google.golang.org/grpc from 1.84.0 to 1.85.0
65996a3 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.84.0 to 1.85.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.84.0...v1.85.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-version: 1.85.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/go_modules/dev/google.golang.org/grpc-1.85.0 branch from ccbdccb to 65996a3 Compare November 2, 2026 09:51
@ImMohammad20000
ImMohammad20000 merged commit 03f66e9 into dev Nov 2, 2026
1 of 2 checks passed
@dependabot
dependabot Bot deleted the dependabot/go_modules/dev/google.golang.org/grpc-1.85.0 branch November 2, 2026 09:59
Free-Guy-IR added a commit to Free-Guy-IR/node that referenced this pull request Nov 2, 2026
@Free-Guy-IR
drift: record the 2026-11-02 upstream items and drop dead waivers
f2712fd 
Upstream Drift found 15 unported items on 0dce28f (12 in scheduled run
41444668606 plus 3 Xray commits pushed today). Each is now recorded:
the dev-only node commits 03f66e9 (PasarGuard#122) and 68e8419 (PasarGuard#121) are pending
until a release carries them, ebb0d02 is superseded by b867989, the
Xray TUN WFP commits are not applicable to the Linux node whose pinned
core has no WFP option, 266df8c6 and f2f292c9 are superseded by their
squash 6cdd323a, and release v26.10.31 is pending until the pin moves.
Fourteen waivers the checker reports as matching nothing or no longer
needed are removed. docs/upstream-parity.md records the heads checked.
Free-Guy-IR added a commit to Free-Guy-IR/node that referenced this pull request Nov 3, 2026
@Free-Guy-IR
test(rpc): RED, Stop hangs behind a GracefulStop that waits on an orp…
b45a71b 
…haned handler

The node shuts its gRPC server down with GracefulStop and falls back to
Stop when the shutdown context expires (controller/rpc/service.go). On
grpc 1.84.0 a GracefulStop that is waiting for a handler whose client
connection has already closed holds the server lock, so the fallback
Stop blocks behind it and the forced shutdown never finishes.

The test serves a held handler through UnknownServiceHandler, closes the
client connection, starts GracefulStop, then requires Stop to return
within 3 s. Adopted from NODE-VERIFY (F-V9-G1).

RED on grpc 1.84.0: go test -race -count=2 ./controller/rpc/grpcstop/
fails both runs with "Stop did not return while GracefulStop waited on a
handler whose connection had closed". The next commit moves grpc to
1.85.0 (upstream PasarGuard#122), which carries the fix (grpc-go #9394).
Free-Guy-IR added a commit to Free-Guy-IR/node that referenced this pull request Nov 3, 2026
@Free-Guy-IR
deps: google.golang.org/grpc 1.84.0 -> 1.85.0
bdd91ef 
Port of upstream PasarGuard#122, matching upstream release v0.5.7 (739eab9), which
pins the same grpc 1.85.0 and genproto/googleapis/rpc
20260817212433-ac3dfec99bb1. go.mod and go.sum match upstream's hunks
exactly; tidy changes nothing further. Tidied with Go 1.26.10. Every new
go.sum line matches sum.golang.org.

What changes on the node's gRPC server, from the v1.85.0 release notes and
the server.go diff: Stop() no longer waits behind a GracefulStop() that holds
the server lock while handlers finish (#9394). The node's shutdown calls
GracefulStop and falls back to Stop when its context expires, so a shutdown
whose GracefulStop is already waiting for a handler that outlived its
connection can now finish. The other server fixes harden the HTTP/2 framing
(stream ids on truncated HEADERS, END_STREAM on HEADERS, requests without
:authority or Host, control buffer throttling). Unchanged between the two
versions: keepalive, the tap handle, TLS credentials, the interceptors and
the message-size limits.

RED: the previous commit, TestNodeVerifyStopEndsAGracefulStopWaitingOnAHandlerWhoseConnectionIsGone
in controller/rpc/grpcstop, fails on 1.84.0: Stop does not return while
GracefulStop waits on a handler whose connection has closed. A raw HTTP/2
wire check of a unary GetBaseInfo whose HEADERS frame carries END_STREAM
was ended at once with Internal "received no request message" on 1.84.0 as
well, so #9391 does not change the node unary path.

GREEN: the grpcstop test passes with -race -count=3 on 1.85.0. go build ./..., GOOS=linux go vet ./... and go mod verify pass.
controller/rpc/access, controller/rpc/keepalive and controller/rpc/preauth
pass with -race on darwin/arm64.

Upstream: 03f66e9
Free-Guy-IR added a commit to Free-Guy-IR/node that referenced this pull request Nov 3, 2026
@Free-Guy-IR
drift: settle the node v0.5.7 waivers
b08ecee 
Upstream released node v0.5.7 (739eab9) on 2026-11-03 with five commits
after v0.5.6.

- 03f66e9 (PasarGuard#122, grpc 1.85.0) and 68e8419 (PasarGuard#121, gopsutil 4.26.10) are
  ported by trailer, so their dev-only pending waivers go.
- ebb0d02 (the WireGuard E2E AppArmor fix) stays superseded; its waiver no
  longer says it is in no upstream tag, since v0.5.7 contains it.
- 81af68e (update dependencies) is pending. It refreshes indirect modules
  for upstream's xray-core pseudo-version, which the fork does not take; the
  waiver names the modules outside the fork's graph and the ones inside it
  that are owed a port with their own test run.
- 739eab9 (the v0.5.7 version bump) is pending as the release tracker, as
  675bdaa is for v0.5.6.
Free-Guy-IR added a commit to Free-Guy-IR/node that referenced this pull request Nov 11, 2026
@Free-Guy-IR
docs(upstream): record PasarGuard#100 and PasarGuard#114 in upstream'…
e681e38 
…s form, and correct three stale rows

The drift check now reports upstream PasarGuard#100 (3be63e1) as ported by
the cherry-pick line of 9f89151 and 4675fbc and said its superseded
waiver was no longer needed, so that row is gone. The PasarGuard#114 row names
the tests' new place, upstream's config_tobytes_test.go (c936200,
f02a59a), and a dated section records the evidence for both.

Corrected after re-checking each fact on 2026-11-11:
- the 36dc7a4 waiver said the fork had not taken PasarGuard#64; c755202 ported
  it on 2026-11-10 without upstream's .gitlab-ci.yml, and
  git log origin/main -- .gitlab-ci.yml is empty;
- PasarGuard#105 (25a8d74) was written as released in v0.5.6;
  git for-each-ref --contains lists upstream tags v0.5.5, v0.5.6 and
  v0.5.7;
- the PasarGuard#121 and PasarGuard#122 rows still said dev-only; v0.5.7 contains both,
  and 62059d0 and bdd91ef ported them on 2026-11-03, after the
  release.

DRIFT_COMPONENTS=node bash scripts/upstream_drift.sh exits 0 with
0 unported items, with DRIFT_TODAY unset and with 2026-11-21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ImMohammad20000