Repository navigation
Fix Google OAuth redirects for Windows and Linux - #44
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows and Linux Google sign-in fails before reaching Google because production redirect validation rejects the client's fixed callback,
http://localhost:43821/auth/callback. Allow that exact URI and document its relationship to the public Google callback. Existing host and scheme configuration continues to apply.Fixes #43. Covers the desktop redirect portion of FR-1_3.
Validation:
VALIDATION_ERRORagainst the public API.tools/papyrus test server -- tests/api/routes/test_auth.py tests/services/test_auth.py: 54 passed, including production-mode callback delivery/code exchange and rejection of unexpected redirect URLs. Google identity exchange is mocked.tools/papyrus check server: Ruff lint/format and Mypy passed.git diff --check: passed.Server deployment is required. No client rebuild, schema migration, dependency, or version change is needed. The client's fixed port remains unchanged. Real Google sign-in on Windows remains to be verified after deployment.