Repository navigation
Fix midnight-dependent goal history test and sync release history - #39
Merged
Merged
Conversation
Release server 0.0.4 after version preparation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deletion-history test failed on #38 at 00:01 UTC because its goal was created 30 minutes earlier, on the previous calendar day. Deleting that recurring goal correctly retains both the completed day and the current partial day, while the test unconditionally expected one archived period.
Use a fixed goal creation time and control the deletion clock. Cover deletion one minute before midnight, exactly at midnight, and one minute after midnight, verifying period boundaries and archival state as well as activity retention and deletion tombstones. Production behavior, dependencies, and version numbers are unchanged.
Validation: all 10 tests in tests/services/test_tracking.py pass against the separate local test database. Repository-wide Ruff, formatting, and Mypy checks pass. git diff --check passes. CI will run the full backend suite.
This branch includes master at c0eef25, so it also performs the release-history synchronization intended by #38. It replaces #38. Merge using Create a merge commit to preserve that ancestry. No new release or deployment is triggered.