Skip to content

Generate EPUB workers at build time and retire stale reader artifacts - #23

Merged
Eoic merged 1 commit into
developmentfrom
maintenance/generated-worker-and-docs
Nov 7, 2026
Merged

Eoic merged 1 commit into
developmentfrom
maintenance/generated-worker-and-docs

Conversation

@Eoic

@Eoic Eoic commented Nov 7, 2026

Copy link
Copy Markdown
Member

Web builds now compile the EPUB worker from Dart with the consuming application's resolved dependencies and license notices. Remove the checked-in JavaScript/notice snapshots and manual regeneration script; imported source, compiler and license changes are tracked by the transformer depfile.

Closes #22.

  • Require Flutter 3.47+, pin CI to 3.47.9, and move to the compatible pdfrx 2.4.8 patch.
  • Keep native bundles free of the web asset. Add disposable-consumer checks for incremental generation, dependency changes, compiler failures and Git-based consumption.
  • Fix reader Material/semantics boundaries exposed by the SDK upgrade, retain normal pointer-based browser coverage, and remove the obsolete macOS architecture workaround.
  • Keep only current reader architecture, integration and validation docs, using uppercase Markdown names; remove implementation reports and template text.

Validation: 235 reader tests and 2 example tests; reader/example formatting and analysis; complete browser smoke (real worker protocol, EPUB/PDF navigation, settings, files and cleanup); seven worker-build regression scenarios; example web and macOS release builds. Checked with Flutter 3.47.9 / Dart 3.13.7. Native device acceptance and Linux/Windows builds are left to CI/platform testing.

The client/workspace integration PRs depend on this commit. No release version changes.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 22:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T22:18:18.037841Z 92ac272 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit a52d0e4 into development Nov 7, 2026
4 checks passed
@Eoic
Eoic deleted the maintenance/generated-worker-and-docs branch November 7, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate EPUB worker during web builds and retire stale reader artifacts

2 participants