Repository navigation
Add isolated contributor proposal for verification-before-sign-in - #93
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Eoic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the verification-before-sign-in contract in
proposals/authentication.rst, with a separate contributor-proposals index. Sphinx explicitly excludes this directory from the published site, navigation, search and requirement export. The manual, requirements and system-design pages remain unchanged.The proposal covers token-free pending registration, password and Google sign-in, resend and verification, refresh rejection, existing-session enforcement, delivery retries, verification evidence, profile isolation and coordinated rollout. Closes #81 (TASK-AUTH-01), covering the verification portions of FR-1_1, FR-1_2 and FR-1_3. Runtime implementation remains in PapyrusReader/server#22 and PapyrusReader/client#60. Parent requirements remain partial and the generated OpenAPI snapshot is unchanged.
Validation: clean
make build,make requirements(84 work items),make test(23 tests), standalone proposal RST validation andgit diff --checkpassed. Verified the proposal is absent from generated HTML, search and work-item export. All eight JSON examples parse, and the successful-token example validates against the current server AuthTokens schema.After review and merge, record contract acceptance and synchronize the project before launching the dependent server task. Deployment and platform acceptance belong to the implementation tasks.