Repository navigation
Use the schema's variant types consistently across datasets - #538
Open
jjacobson95 wants to merge 1 commit into
Open
jjacobson95 wants to merge 1 commit into
jjacobson95 wants to merge 1 commit into
Conversation
Member
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Datasets named some variant types differently. For example, CPTAC used
Start_Codon_SNPwhere others useTranslation_Start_Site, and BeatAML usedFrameshift_Variantwhere others split frameshifts intoFrame_Shift_Ins/Frame_Shift_Del. This maps every dataset to the variant types listed in our schema, one name per variant type, and fixes the problems listed in #532:start_lost/stop_lostrows;Start_Codon_*/Stop_Codon_*→Translation_Start_Site/Nonstop_Mutation; undetermined coding indels → in-frame or frameshift by HGVS lengthFrame_Shift_Ins/Delby HGVS;protein_altering_variant→ in-frame by length;start_lost→Translation_Start_SiteNonsense_Mutation; 5′ UTR →5'UTR; frameshifts split by HGVSintergenic_variant→IGRStart_Codon_*/Stop_Codon_*→Translation_Start_Site/Nonstop_Mutationp.…; removes a?filter that did nothingTwo exceptions remain: Novartis frameshifts are
Frameshift_Variant, since the source only gives them at the protein level, and 17 CPTAC variants the source couldn't classify stayUndetermined.Tested by running each changed build script end to end: the outputs match the corrected files prepared for this update, and no mutations are added or lost, apart from removing the duplicated cell line rows.
Closes #532