Repository navigation
Add validation suite - #520
Merged
Merged
Conversation
jjacobson95
marked this pull request as ready for review
October 27, 2026 20:37
jjacobson95
changed the base branch from
main
to
mpnst-treated-samples-and-omics
October 27, 2026 20:40
jjacobson95
changed the base branch from
mpnst-treated-samples-and-omics
to
main
October 27, 2026 20:40
sgosline
requested changes
Oct 27, 2026
sgosline
left a comment
Member
There was a problem hiding this comment.
can you add some inline comments to this script to help with future debugging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
coderbuild/utils/validate_build.py, run bybuild_all.py --validatebefore the schema check. It catches problems the schema can't see, such as the duplicates in #512. Errors stop the build; warnings are listed for review.3524.0)--previous-summary)Each build publishes
validation_summary.jsonwith its counts of samples, drugs and responses per dataset. Optionally, pass a previous build's summary with--previous-summaryto compare against it; without it, the last check in the table is skipped. To run the checks on any folder:pytest tests/test_build_data.py --build-dir <folder>. Usage is incoderbuild/README.md.Closes #515