Repository navigation
Fix HCMI model types, sample filtering, and omics sample assignment - #517
Merged
Merged
Conversation
Set model type from GDC specimen_type, leave out matched normals, add cancer type mappings for new GDC diagnoses, and assign copy number and mutation files to their tumor sample.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDC no longer fills in the
compositionfield that the HCMI samples script used to decide each sample's model type. As a result, every sample was labelled "patient derived organoid", and tumor and cell line samples were dropped. This PR reads the model type from the field GDC now uses and fixes a few related labelling and mapping problems.Changes:
specimen_typefield: 3D models are "patient derived organoid", 2D models are "cell line", and tumor tissue is "tumor".Before: 1,087 samples, all labelled "patient derived organoid", 229 of them with cancer type "Normal Tissue"; copy number for 318 samples and mutations for 262.
After: 2,129 samples (1,174 organoid, 260 cell line, 695 tumor), none labelled "Normal Tissue"; copy number for 1,098 samples and mutations for 907. Existing samples keep their IDs and omics values.
Closes #513