Skip to content

Fix HCMI model types, sample filtering, and omics sample assignment - #517

Merged
sgosline merged 1 commit into
mainfrom
fix-hcmi-samples
Oct 20, 2026
Merged

sgosline merged 1 commit into
mainfrom
fix-hcmi-samples

Conversation

@jjacobson95

@jjacobson95 jjacobson95 commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

GDC no longer fills in the composition field that the HCMI samples script used to decide each sample's model type. As a result, every sample was labelled "patient derived organoid", and tumor and cell line samples were dropped. This PR reads the model type from the field GDC now uses and fixes a few related labelling and mapping problems.

Changes:

  • Set the model type from GDC's specimen_type field: 3D models are "patient derived organoid", 2D models are "cell line", and tumor tissue is "tumor".
  • Leave out matched normal samples (blood and normal tissue), which were previously labelled "tumor".
  • Add cancer type mappings for 98 diagnoses GDC now reports, and ignore punctuation differences when matching. Cancer models whose diagnosis had no mapping were labelled "Normal Tissue".
  • Assign each copy number and mutation file to its tumor or model sample. These files list both the tumor and its matched normal, and the script used whichever came first, so many profiles were dropped.

Before: 1,087 samples, all labelled "patient derived organoid", 229 of them with cancer type "Normal Tissue"; copy number for 318 samples and mutations for 262.
After: 2,129 samples (1,174 organoid, 260 cell line, 695 tumor), none labelled "Normal Tissue"; copy number for 1,098 samples and mutations for 907. Existing samples keep their IDs and omics values.

Closes #513

Set model type from GDC specimen_type, leave out matched normals, add
cancer type mappings for new GDC diagnoses, and assign copy number and
mutation files to their tumor sample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HCMI model type parameter changed location

2 participants