Repository navigation
Fix BeatAML drug response sample mapping - #516
Merged
Merged
Conversation
Map dbGaP sample ids to labId and cohort with key lookups instead of merges, resolve inhibitor names with parenthetical aliases, and use one improve_sample_id per labId in the experiments step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes how BeatAML dose-response rows are matched to specimens.
generate_raw_drug_filemerged the raw inhibitor table onto the sample map on dbGaP sample ids and assigned the mergedlabIdback by position. Rows without an RNA-seq id matched on the missing key, which misaligned that assignment, so some drug response values were matched to the wrong specimen.Changes:
labIdand cohort with key lookups that skip missing keys.improve_sample_idperlabIdin the experiments step, so duplicated sample rows no longer duplicate dose data.Before: 309 specimens, 139 drugs, 32,211 sample/drug pairs, Spearman 0.47 against the published BeatAML AUCs. After: 631 specimens, 162 drugs, 62,707 pairs, Spearman 0.99.
Closes #514