Repository navigation
Copy number Harmonization - all datasets. - #507
Merged
Merged
Conversation
Each builder converted raw copy number differently, so copy_number was stored on different scales while copy_call applied one set of cutoffs (0.521 / 0.731 / 1.214 / 1.422, on DepMap's log2(relative CN + 1) scale) to all of them. Convert every source to that scale so the stored values are comparable and the calls are correct (0/1/2/3/4 copies -> deep del / het loss / diploid / gain / amp). - Sanger (gdscv1/v2), mpnst, cptac, pancreatic, liver: log2 ratio s -> log2(2^s + 1) - bladder, colorectal: segment log2 ratio -> log2(2^s + 1) (was 2*2^(s/2)) - novartis: absolute copies -> log2(c/2 + 1) - hcmi: absolute ASCAT copies -> log2(c/ploidy + 1), using per-sample tumor_ploidy from the GDC ASCAT segment files (2 if unavailable) - pancreatic: replace its own cutoffs with the shared ones - cptac: fix the 1.42233 gain cutoff typo - coderdata: copy_call bins use -inf/inf so values outside [0, 2] are labelled instead of becoming NaN
sgosline
approved these changes
Oct 6, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline Hardening/Debugging PR # 17
Note: Merge this PR only after all other 2.4 build PRs. Once those PRs are merged, update this branch from
mainand merge. Basically just review and then tell me to merge.Harmonize copy number across datasets
Convert copy-number values to the DepMap log2(relative CN + 1) scale before assigning copy calls.
Additional update:
Also read the HCMI MAF
PUBMEDcolumn as text. Some rows contain multiple semicolon-separated PubMed IDs; treating the column as numeric caused otherwise valid mutation files to be skipped.Closes #506.