Repository navigation
Add schema support for phosphoproteomics and new dataset outputs - #491
Merged
sgosline merged 3 commits intoSep 29, 2026
Merged
Conversation
jjacobson95
force-pushed
the
build-orchestration-and-safety
branch
from
September 21, 2026 21:55
cfa266d to
5be9072
Compare
jjacobson95
force-pushed
the
schema-phosphoproteomics
branch
from
September 21, 2026 21:55
1d6624f to
31d396c
Compare
Member
|
We are not including cNF and phosphosite in this build |
Improve schema validation, ID mapping, and IMPROVE export
ymahlich
reviewed
Sep 28, 2026
Collaborator
There was a problem hiding this comment.
I am guessing that the same as with the other issues that contain CNF applies here as well, i.e. we keep the code but don't include the CNF data in the bulid?
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline Hardening/Debugging PR # 13
Add schema support for phosphoproteomics and new dataset outputs
Extends the CoderData schema so the new phosphoproteomics data type, the phosphosite reference, and the single-dose viability metric are all valid, and declares the expected output files for the new datasets. Must merge after the dataset PRs that produce these outputs, or schema validation will fail on files that don't exist yet.
Data model additions (
schema/coderdata.yaml)phosphosite_id: a new integer identifier slot for a phosphorylation site (gene + residue + position).Phosphositeclass: the reference table produced by the phosphosites builder; each row is a unique gene/residue/position withentrez_id,gene_symbol,residue,position, andmodification.Phosphoproteomicsclass: per-sample phosphoproteomics measurements, keyed byphosphosite_idandimprove_sample_id, storing the log-normalized, batch-corrected abundance value.uM_viabilityadded to theResponseMetricenum (single-dose viability fraction at 1 μM), so the cNF single-concentration experiment values validate.Expected-file declarations (
schema/expected_files.yaml)Combinationstarget and the novartis drug-descriptor file to keep the expected-file list in sync with the current builders.Merge-order requirement
expected_files.yamlreferences outputs those PRs generate; landing this first would make the schema check fail.Scope: 2 files. Base: build-orchestration-and-safety.
Related issues
Closes #469