This repository was archived by the owner on Oct 30, 2026. It is now read-only.
Repository navigation
Fix installed-package test fixtures - #14
Merged
henrikklee merged 4 commits intoOct 30, 2026
Merged
henrikklee merged 4 commits into
henrikklee merged 4 commits into
Conversation
The installed-wheel checks invoke resolve without its required profile. Select j71b so these tests exercise package independence against the current command contract. Signed-off-by: Shayne Legault <8741557+shaynelegault@users.noreply.github.com>
Python virtualenvs may expose the trusted hardware package through a lib64 link. Resolve the fixture path before checking the package data with the strict local bundle validator. Signed-off-by: Shayne Legault <8741557+shaynelegault@users.noreply.github.com>
shaynelegault
marked this pull request as ready for review
October 30, 2026 03:20
shaynelegault
marked this pull request as draft
October 30, 2026 03:22
Signed-off-by: Shayne Legault <8741557+shaynelegault@users.noreply.github.com>
Signed-off-by: Shayne Legault <8741557+shaynelegault@users.noreply.github.com>
shaynelegault
force-pushed
the
codex/p105-resolve-test-fixtures
branch
from
October 30, 2026 03:27
c97d6c8 to
9016fea
Compare
shaynelegault
marked this pull request as ready for review
October 30, 2026 03:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed-package tests call
resolvewithout the profile required by the current CLI. A trusted device fixture can also be reached through a virtualenvlib64symlink on Linux. These cases are among the failures reported in #13. Current main also moved the IPSW implementation while one boundary test still imports its old module name.This test-only change supplies the J71b profile, resolves the installed fixture path before checking its local receipts, and imports the current shared Apple modules in the boundary test.
Validation:
lib64symlink.ae1457e, built hardware 0.1.11 from source, and passed all 245 tests on GitHub-hosted Ubuntu 24.04 x86-64 with Python 3.9 and 3.12.action_requiredwith no jobs run. Its default released hardware 0.1.10 does not satisfy the current CLI dependency on hardware 0.1.11. The separately tested CI change is in ci: align hardware dependency for development checks #15, which builds on this draft.