This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Put Nav at top of page, not on top of landing banner.聽#459
Description
I had originally left this vague as I initially planned on simply doing it myself when I wrote the ticket.
Terrible idea 馃槀
Anyways... further details:
Right now, in the DOM, the navbar (<Header>) is located atop the router switch, but nested within the div whose background image is dynamically selected per route. See here.
Architecturally, I'd rather have the header be at the top of the DOM tree, and have a "backgroundImageSrc" prop which can be handled in the same current manner.
With this work done:
- We can have a sticky navbar
- We can avoid re-renders (currently, when switching between routes the entire navbar re-renders unless switching between two routes without a hero image)
Activity
raphaabrasil commentedon Oct 6, 2017
@kylemh Can i help you on this?
kylemh commentedon Oct 7, 2017
@raphaabrasil I've definitely become too busy to tackle the string of tasks related to the Nav refactor. I'll be tagging you - and all the other developers that have expressed interest in the Nav - on a better documented series of issues as soon as possible.
raphaabrasil commentedon Oct 9, 2017
@kylemh Ok, i'll wait for it :)
jjhampton commentedon Jan 29, 2018
I've thought for a while that it would be nice to be able to scroll down the page and see a 'sticky' nav at the top of the screen that still shows the nav items, instead of the nav disappearing off screen when scrolling. We could switch to an opaque color (from the branding guide, possibly the same as the header on other pages or the footer).
@raphaabrasil Are you still interested in tackling this?
JennWeideman commentedon Feb 14, 2018
Status who's got this @jjhampton @raphaabrasil
jjhampton commentedon Feb 14, 2018
@JennWeideman This is currently being worked on by @dave5801 (and has an open PR under review). I will assign myself as a placeholder for now.
JennWeideman commentedon Feb 15, 2018
Thank you! I just read the PR is he working on your requested changes @jjhampton
jjhampton commentedon Aug 15, 2018
Unassigning myself from this issue - the original PR issued to address this is stale, and we'll need a new PR to address these requirements.
This issue is open to any contributors who want to take it on!
kylemh commentedon Aug 22, 2018
Closing this issue in the spirit of preventing work on items that would not be implemented in the new repository.
The nav rework is underway there.