You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Create Jest snapshot tests of every shared component #327
@seeksort yes indeed! Wow, I was so excited to see this issue pop up in my notifications. You'll be integrating our first tests!!! I've assigned myself to this issue as a placeholder for you.
Still working on this, I've just been busy. I had a question though, what are everyone's thoughts on having a central __tests__ directory vs. a subdirectory in each component subfolder? Ryan Florence of React Router suggests having a separate__tests__ subdirectory for each component. I've seen it done both ways, though.
@seeksort no problem, as it seems you're the only person interested in helping with tests 😆
I'm really not experienced enough to have an opinion on the matter. My first inclination is to stick with what people are most familiar with in a central __tests__ directory, since we work with many new developers. I see Ryan Florence's points, but what do you think?
Activity
[-]Integrate Unit Test Framework[/-][+]Create Jest snapshot tests of every shared component[/+]seeksort commentedon Oct 7, 2017
Hello! Could I take on this one? This would be for all of the components in
/src/shared/components, right?kylemh commentedon Oct 7, 2017
@seeksort yes indeed! Wow, I was so excited to see this issue pop up in my notifications. You'll be integrating our first tests!!! I've assigned myself to this issue as a placeholder for you.
seeksort commentedon Oct 21, 2017
Still working on this, I've just been busy. I had a question though, what are everyone's thoughts on having a central
__tests__directory vs. a subdirectory in each component subfolder? Ryan Florence of React Router suggests having a separate__tests__subdirectory for each component. I've seen it done both ways, though.kylemh commentedon Oct 22, 2017
@seeksort no problem, as it seems you're the only person interested in helping with tests 😆
I'm really not experienced enough to have an opinion on the matter. My first inclination is to stick with what people are most familiar with in a central
__tests__directory, since we work with many new developers. I see Ryan Florence's points, but what do you think?kylemh commentedon Aug 22, 2018
Closing this issue in the spirit of preventing work on items that would not be implemented in the new repository. This is already implemented there.