You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
@mwagz to be clear - the wireframe is a great guideline, but do not use the same image header.
If you are able to replicate the curved hero bottom border, please try to cordon off that code for us to use on the landing page! 👍 also keep in mind that I'll be refactoring Nav/Header this weekend. Let me know if you implement any ideas so I don't reinvent the wheel. Consider using the
component as it is being used for the landing page within home.js
@kylemh I didn't do anything crazy, but I did use as many pre-existing components as I was able to identify. For the curved hero bottom border, I came up with a solution that I'm not totally proud of, but it accomplishes the task.
There are 2 components in my PR, HeaderClipMaskLeft and HeaderClipMaskRight. These components are absolutely positioned to the first section on the page (the quote, in my case). I then set that section to be relatively positioned and include these new components in the Section. Reference is here.
These components could use some expanding upon. They're currently restricted to white and using props we could probably just use one component for both sides.
Outside of that stuff, I think I honored everything you outlined. I did take some liberties on mobile breakpoints.
With this page not mapped out as an aspect of parity, it'll be subject to redesign before creating a new issue on the new repo. Leaving open until redesign is prepared.
Activity
hollomancer commentedon Jun 14, 2017
@RobKriner, I believe we had a design for this already...
hollomancer commentedon Jun 14, 2017
alexspence commentedon Jun 15, 2017
I've actually already done alot of the work for this page, as I was using it as the original homepage. components are in scenes/home/families.
If no one else picks it up I can probably tackle it in a few days.
hollomancer commentedon Jun 15, 2017
Once this page is up, I have some followup work to redirect Google Adwords to this page as a landing.
11 remaining items
kylemh commentedon Sep 9, 2017
@mwagz to be clear - the wireframe is a great guideline, but do not use the same image header.
If you are able to replicate the curved hero bottom border, please try to cordon off that code for us to use on the landing page! 👍 also keep in mind that I'll be refactoring Nav/Header this weekend. Let me know if you implement any ideas so I don't reinvent the wheel. Consider using the
component as it is being used for the landing page withinhome.jsIssue OperationCode#154 - Create Military Families Page
mwagz commentedon Sep 10, 2017
@kylemh I didn't do anything crazy, but I did use as many pre-existing components as I was able to identify. For the curved hero bottom border, I came up with a solution that I'm not totally proud of, but it accomplishes the task.
There are 2 components in my PR,
HeaderClipMaskLeftandHeaderClipMaskRight. These components are absolutely positioned to the first section on the page (the quote, in my case). I then set that section to be relatively positioned and include these new components in the Section. Reference is here.These components could use some expanding upon. They're currently restricted to white and using props we could probably just use one component for both sides.
Outside of that stuff, I think I honored everything you outlined. I did take some liberties on mobile breakpoints.
Issue OperationCode#154 - Create Military Families Page
Issue OperationCode#154 - Create Military Families Page
JennWeideman commentedon Jan 23, 2018
https://www.123rf.com this is a site full of free stock images. It might be nice if we could change up the images now and then
kylemh commentedon Jan 24, 2018
This page is nearly done. Somebody may feel free to hijack @mwagz's work to finish
Merge pull request OperationCode#154 from coloradojay/bug-130-team-me…
kylemh commentedon Oct 1, 2018
With this page not mapped out as an aspect of parity, it'll be subject to redesign before creating a new issue on the new repo. Leaving open until redesign is prepared.
Merge pull request OperationCode#154 from OperationCode/chore/leaders…