This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Repository navigation
Bug: more error fixing attempts. - #392
Merged
Merged
Conversation
nellshamrell
approved these changes
Sep 4, 2018
This was referenced Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still getting sentry raven errors.
The previous PR might have stopped new jobs, but I am unable to verify that. Since the previous PR didn't modify the jobs, but only the methods to add items to the queue the jobs were still around and retrying:
jobstr: {"class":"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper","wrapped":"SendEmailToLeadersJob","queue":"default","args":[{"job_class":"SendEmailToLeadersJob","job_id":"e83f8353-6bcb-4ead-b199-22dbafc37d53","queue_name":"default","priority":null,"arguments":[5634],"locale":"en"}],"retry":true,"jid":"ba5c804c14e5326cd71282a2","created_at":1534575086.2258425,"enqueued_at":1536011868.7118113,"error_message":"FATAL: database \"opcode-postgres\" does not exist\n","error_class":"ActiveRecord::NoDatabaseError","failed_at":1534575086.2729545,"retry_count":23,"retried_at":1535731542.3347352}The above job was added to queue on 8-18-2018 and has been retried 23 times.
ex: https://repl.it/repls/HandsomeFlawedApi
This PR adds a maximum retry count of 5. Using information found: https://repl.it/repls/HandsomeFlawedApi
I don't know how to test this config actually works, and I'd like to be able to see how many jobs are in a retry queue.