This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Run migrations on container start #61
Description
Feature
Why is this feature being added?
Migrations currently have to be run manually once they hit production.
What should your feature do?
Create a script that will do any startup related tasks (eg rails db:migrate).
It should end with bundle exec puma -C config/puma.rb
Activity
kirbyfern commentedon Jun 20, 2017
Is this related to heroku threads? or Procfile if thats the case I can have this issue. Let me know if this is the Procfile and puma.rb
rickr commentedon Jun 20, 2017
No - this will be a little shell script that's run as Docker's start script.
kirbyfern commentedon Jun 20, 2017
ok
PSkaggs commentedon Aug 27, 2017
I can do this.
hpjaj commentedon Oct 13, 2017
@PSkaggs - Are you still interested in taking this on? If yes, its yours! Just let us know so we can mark it as in progress.
PSkaggs commentedon Oct 13, 2017
Sure, I'll take it.
hpjaj commentedon Oct 13, 2017
@PSkaggs - it is yours!
PSkaggs commentedon Oct 19, 2017
@hpjaj I'm not sure what all you wanted with this feature. I currently have a script that runs migrations when starting the container. Did you want the database seeded as well?
hpjaj commentedon Oct 19, 2017
@PSkaggs - No, no seeding. Just want to make sure that the migrations are ran when the container starts.
PSkaggs commentedon Oct 20, 2017
I suppose I'm a little confused as to how you are running this in production. If you are using
yarnthen there is already amake db_migratein the script. Unless you are just usingmakeordocker-compose up --buildor something similar? Anyway, I've got a PR for you that does what you want.hpjaj commentedon Oct 20, 2017
As it stands today, we have to have someone manually run
rake db:migratein prod, after any PR's are merged with pending migrations.That said, this issue was requested by @rickr . That would be a good question for him, or perhaps @ohaiwalt .
Either way, @ohaiwalt , can you please code review #186
kylemh commentedon Oct 23, 2017
@ohaiwalt does this maybe explain our server outage per build?
ohaiwalt commentedon Oct 29, 2017
@kylemh negative, unrelated.
hpjaj commentedon Nov 23, 2017
Completed: #186