Repository navigation
Pr/events page - #353
Pr/events page#353
Conversation
|
This pull request is automatically deployed with Now. |
|
🤖 This is a bot 🤖 Built with commit 3ba7e14 https://deploy-preview-353--operation-code-storybook.netlify.com |
|
🤖 This is a bot 🤖 Built with commit bcbdbae https://deploy-preview-353--operation-code-storybook.netlify.com |
kylemh
left a comment
kylemh
left a comment
There was a problem hiding this comment.
Can you get rid of the XML lines from all the SVGs?
Also, check out the attributes I've removed from the previous FA Icons. I'd appreciate you removing them from the actual SVGs until I upgrade our SVGO dependency and automate that. You'll reduce the overall bundle.
|
Great job! Looks nice on immediate view. I'll check this out deeper late tonight. |
|
Awesome work. Love all the deleted diff in the last two commits 🤤 |
kylemh
left a comment
kylemh
left a comment
There was a problem hiding this comment.
Just wanna make sure my thought isn’t actionable before I approve. Very nice on the stylings for solid buttons always 💪
| position: absolute; | ||
| margin: 0 auto; | ||
| left: 0; | ||
| right: 0; |
There was a problem hiding this comment.
Now that’s what I’m talking about. 🥰
|
|
||
| .meetupCard > div { | ||
| padding: 2rem; | ||
| } |
There was a problem hiding this comment.
Do you think these style overrides should be applied to all FlatCards too? Compare result against Success Story on homepage or the component itself on Storybook. I feel like we can deliver something that works for all usages without any style overrides.
This branch was successfully deployed
2 participants
Description of changes
Build /events page matching new mock design.
Issue Resolved
Fixes #166