Skip to content

fix(climate): restore season and fan_coil_sides across restarts and bridge dim 19 is_active (#714) - #715

Merged
GreenGrassBlueOcean merged 1 commit into
v2-phase1-architecturefrom
fix/f461-live-plant
Oct 15, 2026
Merged

GreenGrassBlueOcean merged 1 commit into
v2-phase1-architecturefrom
fix/f461-live-plant

Conversation

@GreenGrassBlueOcean

Copy link
Copy Markdown
Contributor

Follow-up to #714 (and companion to OpenWebNet-HA/OWNd#116):

Changes

  1. State Restoration (climate.py): Restore season, fan_coil_heating, and fan_coil_cooling in MyHOMEClimate.async_restore_last_state() so _season_has_fan_coil() immediately skips winter *#4*Z*11## polls on restart before the next Dimension 19 frame arrives.
  2. Dimension 19 is_active Bridge (climate.py): Bridge OWNd <= 2.0.0b11 (until OWNd#116 is released) where a fan-coil value 5 (fan off) on one side of a Dimension 19 frame (*#4*2*19*5*1##) cleared _is_active to False even when the other side's valve was open (is_heating() == True), ensuring hvac_action immediately reports HEATING / COOLING.
  3. Inline Comment Alignment (climate.py): Remove F461 from the unsupported-gateway comment in MyHOMEClimate.async_update() to match gateway.py.
  4. Tests (tests/test_f461_live_plant.py):
    • Add test_restore_last_state_preserves_season_and_fan_coil_sides verifying restored attributes and season-gated fan polling.
    • Assert zone.hvac_action == HVACAction.HEATING directly on *#4*2*19*5*1## in test_dimension_19_records_which_side_is_a_fan_coil.
  • V2 Architecture: Existing handle_event() and async_restore_last_state() extended; 100% statement coverage on modified files.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@GreenGrassBlueOcean
GreenGrassBlueOcean merged commit 4e13a90 into v2-phase1-architecture Oct 15, 2026
17 checks passed
@GreenGrassBlueOcean
GreenGrassBlueOcean deleted the fix/f461-live-plant branch October 21, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants