Repository navigation
feat(config-flow): start new gateways at the profile's default command sessions - #606
Merged
GreenGrassBlueOcean merged 2 commits intoOct 2, 2026
Conversation
…d sessions A new entry hard-coded one command worker, and the options form offered the profile's whole limit with no hint that every session plus the event session takes one of the gateway's few connections (an F455 allows five in all, shared with the vendor app). command_session_default() now returns the profile's default_command_sessions, clamped to its limit and 1 for unknown models or older OWNd profiles, for every gateway. New entries start there, and the options form says what is recommended and why. Follow-up to the review on OpenWebNet-HA/OWNd#76. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CI's pinned OWNd has no H4890 profile, so its limit is None and the default 1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GreenGrassBlueOcean
merged commit Oct 2, 2026
705596d
into
OpenWebNet-HA:v2-phase1-architecture
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the review on OpenWebNet-HA/OWNd#76: MyHOME only used the gateway profile's
max_command_sessions(as the ceiling for the worker count) and neverdefault_command_sessions. New entries hard-coded 1 worker and the options form offered the whole limit, so an F455 user could pick 4 command sessions plus the event session and use all 5 sockets, leaving none for the Legrand app or a reconnect overlap.command_session_default(model)returns the profile'sdefault_command_sessions, clamped to its limit; 1 for unknown models or older OWNd profiles without the field. It works for every gateway profile.Today only MyHomeServer1 has a default above 1 in OWNd 2.0.0b6; F455 follows once OWNd#76 sets its default to 2. No MyHOME change is needed for that.
Tests
New
tests/test_command_session_default.pycovers every profile, unknown models and clamping.One existing assertion updated for the new
session_defaultplaceholder. Full suite, ruff andverify_ha_standards.pypass.V2 Architecture: New entities implement
handle_event()and do not manually subscribe viaasync_dispatcher_connect. (No entities touched.)🤖 Generated with Claude Code