Skip to content

Bug#39033858 Parallel_reader::Scan_ctx::copy_row copies wrong range of bytes - #96

Merged
willhan123 merged 1 commit into
OpenTenBase:8.0.30from
Wen-He:b_parallel_reader
Jun 7, 2026
Merged

willhan123 merged 1 commit into
OpenTenBase:8.0.30from
Wen-He:b_parallel_reader

Conversation

@Wen-He

@Wen-He Wen-He commented Jun 6, 2026 •

Copy link
Copy Markdown
Collaborator

issue #95 Bug#39033858 Parallel_reader::Scan_ctx::copy_row copies wrong range of bytes

Problem:

InnoDB uses a convention where rec pointers point in between two fragments of the record: to the left of it, are so called "extra" bytes which contain metadata such as flags, info about which fields are null and what is their length. To the right of it, is the actual data of the fields.
The function rec_offs_size(offsets) returns the total length of the record which is the sum of these two:

rec_offs_data_size(offsets) + rec_offs_extra_size(offsets)

The logic of Parallel_reader::Scan_ctx::copy_row() copied that many bytes into a freshly allocated buffer, but used rec address as the source, instead of "rec - extra", resulting in copying wrong range of bytes.

Solution:

Adjust the logic to copy the correct range of bytes.

Change-Id: Ia0463e4a752dfce70ff5a2ac83818132de9a638c

…f bytes

Problem:

InnoDB uses a convention where rec pointers point in between two
fragments of the record: to the left of it, are so called "extra"
bytes which contain metadata such as flags, info about which fields are
null and what is their length. To the right of it, is the actual data of
the fields.
The function rec_offs_size(offsets) returns the total length of the
record which is the sum of these two:
```
rec_offs_data_size(offsets) + rec_offs_extra_size(offsets)
```
The logic of Parallel_reader::Scan_ctx::copy_row() copied that many
bytes into a freshly allocated buffer, but used rec address as the
source, instead of "rec - extra", resulting in copying wrong range of
bytes.

Solution:

Adjust the logic to copy the correct range of bytes.

Change-Id: Ia0463e4a752dfce70ff5a2ac83818132de9a638c
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jakub Łopuszański seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@willhan123
willhan123 merged commit a2888af into OpenTenBase:8.0.30 Jun 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants