Repository navigation
Conversation
Settings registered through setConfig win over the window globals uicore
has always read; unset keys keep the window fallback, so existing
consumers are unaffected. A key set to undefined or an empty string is
unset; null, false and 0 are values (oauth2UseRefreshToken: false turns
the refresh flow off).
The state lives on globalThis under
Symbol.for('openstack-uicore-foundation.config'), so every copy of the
module shares it: bundles that inline it, nested installs, and symlinked
dev checkouts.
getServerTime fetched whatever getTimeServiceUrl returned, so an
unconfigured host produced a garbage request ('' fetches the current
page, undefined fetches the literal string) before landing on the same
local-clock fallback a rejected fetch reaches directly.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
readConfig and setConfig used bare globalThis. They now use the same
_global fallback (globalThis → window → {}) as the security methods, so
the window-globals fallback still works on a runtime without globalThis.
getUserInfo split the allowed-user-groups string whenever it was not '', so the null value getAllowedUserGroups returns with no window threw. parseUserGroups splits a truthy string and returns an empty list for any falsy value; getUserInfo calls it.
smarcet
requested review from
santipalenque and
smarcet
and
a balanced review from Copilot
and removed request for
smarcet
October 27, 2026 20:04
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the opt-in configuration changes.
No open issues 🎉
What changed in this PR
Adds opt-in setConfig support so consumers can supply uicore settings directly while retaining window-global fallbacks. Configuration is shared across package copies using the same global-symbol pattern as the access-token resolver.
Changes:
- Adds a public configuration module and preserves existing getter exports.
- Routes security, API, clock, and exclusive-section settings through configuration getters.
- Adds tests for overrides, fallbacks, resets, shared state, and server-side reads; skips clock requests when no endpoint is configured.
| File | Description |
|---|---|
webpack.common.js |
Exposes the utils/config entry point. |
src/utils/query-actions.js |
Imports API URL construction from config. |
src/utils/methods.js |
Re-exports relocated configuration getters. |
src/utils/config.js |
Adds shared configuration storage, getters, and group parsing. |
src/utils/__tests__/config.test.js |
Tests overrides, resets, and cross-copy sharing. |
src/utils/__tests__/config-reads.test.js |
Tests window fallbacks and legacy exports. |
src/utils/__tests__/config-no-window.test.js |
Tests defaults and overrides without a window. |
src/components/security/reducers.js |
Reads OAuth settings from config. |
src/components/security/methods.js |
Uses and re-exports centralized OAuth getters. |
src/components/security/actions.js |
Uses configured API URLs and allowed-group parsing. |
src/components/security/abstract-auth-callback-route.js |
Reads callback OAuth flow from config. |
src/components/security/abstract-auth-callback-route-v2.js |
Reads callback OAuth flow from config. |
src/components/security/__tests__/get-user-info.test.js |
Updates mocks to target the config module. |
src/components/exclusive-wrapper.js |
Reads exclusive sections through config. |
src/components/clock.js |
Uses configured time endpoint and skips requests when absent. |
Review effort: Balanced
Collaborator
|
@gcutrini please review CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86bcdq027
5.x sibling of #351 (v4.x). Based on #329 (resolver 5.x).
uicore reads its OAuth/app settings (
apiBaseUrl,idpBaseUrl,oauth2ClientId,timeApiUrl) from window globals by default.setConfiglets a consumer hand uicore those settings directly; the config readers (clock, exclusive-wrapper, auth-callback routes, security actions/methods) delegate to it when a config is registered, otherwise the built-in window-globals flow is unchanged. Shared through aglobalThisSymbol.for slot, consistent with the resolver (#329).