Skip to content

feat: show item notes in sponsor order grid - #347

Merged
smarcet merged 3 commits into
mainfrom
feature/sponsor-order-grid-show-notes
Oct 5, 2026
Merged

smarcet merged 3 commits into
mainfrom
feature/sponsor-order-grid-show-notes

Conversation

@santipalenque

@santipalenque santipalenque commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

ref: https://app.clickup.com/t/9014802374/86bcbued9

Show item notes in SponsorOrderGrid
Allows inject row in MuiTable

Summary by CodeRabbit

  • New Features
    • Sponsor order details now display nonblank notes alongside the related item. Blank or missing notes are omitted, and item notes can be hidden without hiding cart notes.
    • Tables can display custom row content while preserving row order and accounting for action columns. Rows without custom content continue to display as before.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f599b394-1332-4cd2-8c88-6232dbf6e22f
📥 Commits

Reviewing files that changed from the base of the PR and between 4a5819c and 4f5e5af.

📒 Files selected for processing (6)
  • package.json
  • src/components/mui/SponsorOrderGrid/__tests__/SponsorOrderGrid.test.js
  • src/components/mui/SponsorOrderGrid/index.js
  • src/components/mui/__tests__/mui-table.test.js
  • src/components/mui/tables/mui-table/index.js
  • src/i18n/en.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

MuiTable now supports custom row rendering. SponsorOrderGrid carries item notes into its rows and displays nonblank notes with a translated label. The new hideItemNotes prop suppresses item notes without hiding cart notes.

Changes

Table rendering and sponsor item notes

Layer / File(s) Summary
Custom row rendering
src/components/mui/tables/mui-table/index.js, src/components/mui/__tests__/mui-table.test.js
Rows with renderRow display the callback output and receive the total column count. Tests cover row order and action-column count.
Sponsor order item notes
src/components/mui/SponsorOrderGrid/index.js, src/components/mui/SponsorOrderGrid/__tests__/SponsorOrderGrid.test.js, src/i18n/en.json, package.json
SponsorOrderGrid carries item notes into row data and displays nonblank notes with a translated label unless hideItemNotes is enabled. Tests cover blank notes and hiding item notes while retaining cart notes. The English translation and package version are updated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 4f5e5

No merge-blocking issue is identified; the change is ready for normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: showing item notes in SponsorOrderGrid.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@santipalenque
santipalenque requested review from smarcet and tomrndom and removed request for smarcet October 2, 2026 19:49
@smarcet smarcet assigned smarcet and santipalenque and unassigned smarcet Oct 5, 2026
@smarcet
smarcet requested review from smarcet and a balanced review from Copilot October 5, 2026 12:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A truthy non-function renderRow field can crash the generic table.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds item notes to the sponsor order ledger and introduces custom row rendering for MuiTable.

Changes:

  • Displays nonblank item notes with an opt-out property.
  • Adds renderRow support to MuiTable.
  • Adds translations, tests, and a prerelease version bump.
File Description
src/​i18n/​en.json Adds the note label.
src/​components/​mui/​tables/​mui-table/​index.js Supports custom row rendering.
src/​components/​mui/​SponsorOrderGrid/​index.js Displays item notes.
src/​components/​mui/​SponsorOrderGrid/​__tests__/​SponsorOrderGrid.test.js Tests item-note behavior.
src/​components/​mui/​__tests__/​mui-table.test.js Tests custom rows.
package.json Bumps the package version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

<TableBody>
{data.map((row) => (
{/* rows with renderRow (e.g. NotesRow) replace the default row, receiving the column count */}
{data.map((row) => row.renderRow ? (

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit ed32224 into main Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants