Repository navigation
Make the coordinate frames of the panels use the same convention as the kite body frame - #92
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
|
jellepoland
approved these changes
Mar 5, 2025
jellepoland
left a comment
jellepoland
left a comment
Collaborator
There was a problem hiding this comment.
All transformations have been made correctly
x -> z
y -> x
z -> y
1-Bart-1
pushed a commit
that referenced
this pull request
Jul 1, 2026
Make the coordinate frames of the panels use the same convention as the kite body frame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, the panel frames align with the body frame of a rectangular wing and they are easier to understand.
x_airf along chord from le to te
y_airf spanwise
z_airf = x_airf cross y_airf