Skip to content

cleanup: the generate_airfoils changelog entry sits under the released #313

Closed

Description

@1-Bort-1

cleanup: the generate_airfoils changelog entry sits under the released v5.1.0 header

#294 merged from 4b261f0 while v5.1.0 was being cut, so CHANGELOG.md now files

- `generate_airfoils` fits the contour it is handed rather than shrink-wrapping it a second time. …

under ## VortexStepMethod v5.1.0 2026-09-11, a release that shipped without it. It belongs in the ## Unreleased section that already exists above it. bin/release reads the top section, so leaving it there puts the fix in the notes of a tag that does not contain it.

Two commits on agent/BeyondTheSim.jl-17 already do exactly this and did not make the merge — 5a4b7ec moves the entry, a820826 folds the two-line inline comment in test/airfoil_aero/test_airfoil_aero.jl into one line (CLEAN_CODE.md §3). Cherry-pick both off that branch.

+6 / -8, no code and no test behaviour.

Activity

  1. 1-Bort-1 commented on Sep 12, 2026

    @1-Bort-1
    MemberAuthor

    Nothing to cherry-pick: #314 already is those two commits. It is open on the same branch agent/BeyondTheSim.jl-17, targets main, is not a draft, and its whole diff against main is exactly this move — 5a4b7ec putting the entry back under ## Unreleased and a820826 folding the comment in test/airfoil_aero/test_airfoil_aero.jl. git diff origin/main...refs/pull/314/head --stat gives +7 / -8 across those two files and nothing else, byte-identical to what a cherry-pick here would produce.

    So merging #314 is what closes this. It reads MERGEABLE, review required, CI re-running. A branch of my own would be the same diff twice and would conflict with #314 on whichever merged second, so I pushed nothing and opened no PR.

    If you would rather have the changelog straight before #314 is reviewed, say so and I will open the standalone cleanup: PR off main with just those two commits — then #314 drops to no diff at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions