Repository navigation
ci: Build and deploy the website from main - #222
Draft
olafmersmann wants to merge 1 commit into
Draft
olafmersmann wants to merge 1 commit into
olafmersmann wants to merge 1 commit into
Conversation
… in PRs Regenerating the HTML in pull requests needs a write token, so it only worked for branches in this repository, not for forks. Making it work for forks (pull_request_target) would run untrusted PR code with write access. Now PRs only check that the site builds, and only main deploys it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of committing HTML in PRs, rebuild the website on merge into main only.
Regenerating the HTML in pull requests needs a write token, so it only worked for branches in this repository, not for forks. Making it work for forks (pull_request_target) would run untrusted PR code with write access. Now PRs only check that the site builds, and only main deploys it. This also eliminates the extra commits introduced by each PR and the possible merge conflicts caused by the divergent html files.