Skip to content

When running the library testing, stick to the exact versions required of dependencies #214

Open

Description

@casella

Currently, when we test libraries in the CI, we load dependencies with the default option, which is to load the dependencies using the latest available backwards-compatible version installed.

I think this is a good idea to do that on the user side. Now that we have MSL 4.1.0, in most cases it makes sense to use it instead of MSL 4.0.0 even though the library has uses(Modelica(version = "4.0.0")). This also allowed us to find some regressions caused by the MSL 4.0.0 -> 4.1.0 because of eps, small, inf, see https://libraries.openmodelica.org/branches/history/master/2025-05-27%2004:24:08..2025-05-28%2004:06:49.html

However, for regular CI testing, I think we should set requireExactVersion = true. The main reason is that new versions are backwards-compatible from an interface point of view, but they often contain bug-fixes and changes that may lead to (sligthly) different results. Those results are likely to be of better quality, but they are not the reference results provided for verification testing, so they will actually lead to verification failure.

Activity

  1. adrpo commented on Jun 10, 2025

    @adrpo
    Member

    You mean this requireExactVersion = true should be the default and for libraries that like maint/N.M.P we should explicitly say requireExactVersion = false?

  2. casella commented on Jun 10, 2025

    @casella
    CollaboratorAuthor

    I don't want to change the default for requireExactVersion, I think it's fine to have it false in general. What I mean is, when we load libraries for CI testing we should stick to the version of the uses annotation.

  3. casella commented on Jun 10, 2025

    @casella
    CollaboratorAuthor

    Not only for the library being loaded, but also recursively for all the library dependencies. Otherwise, the number of possible combination of newer backwards-compatible libraries loaded as dependencies can blow up exponentially. We don't really want that, we only test with the libraries declared in the uses annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions