Skip to content

arm: dts: hi3516a: enable uart1-3 so boards can mux them for PTZ #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
widgetii merged 1 commit into from
Oct 19, 2026
Merged

arm: dts: hi3516a: enable uart1-3 so boards can mux them for PTZ #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions arch/arm/boot/dts/hi3516a-demb.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,18 @@
status = "okay";
};

&uart1 {
status = "okay";
};

&uart2 {
status = "okay";
};

&uart3 {
status = "okay";
};
Comment on lines +90 to +100

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. The ptz pads stay in gpio mode 📎 Requirement gap ≡ Correctness

The enabled UART nodes contain only status = "okay" and add no board-specific pinmux configuration
for the PTZ connection. Because the relevant pads remain GPIO unless the board configures them
separately, this implementation does not verify or configure the physical UART path required by the
motor controller.
Agent Prompt 
## Issue description
The change enables three UART controllers but does not configure the board-specific pads for the PTZ motor-controller connection, leaving the physical interface in its reset GPIO mode.

## Fix Focus Areas
- arch/arm/boot/dts/hi3516a-demb.dts[90-100]

## Recommended Fix
Verify which UART and physical pads connect to the PTZ MCU on the target board, then add the corresponding board-specific pinctrl and any required RS-485 direction GPIO configuration. Enable only the verified UART path and document the board-specific mapping.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


&dual_timer0 {
status = "okay";
};
Expand Down
3 changes: 3 additions & 0 deletions arch/arm/boot/dts/hi3516a.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
/ {
aliases {
serial0 = &uart0;
serial1 = &uart1;
serial2 = &uart2;
serial3 = &uart3;
Comment on lines +26 to +28

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Ptz movement remains unvalidated 📎 Requirement gap ☼ Reliability

The change creates stable serial aliases and enables the UART controllers but adds no serial
communication test or PTZ protocol configuration. Without testing the configured device against the
motor controller using the applicable settings, users have no demonstrated path to pan, tilt, or
zoom control.
Agent Prompt 
## Issue description
The UART aliases and enablement do not establish that the PTZ motor controller is reachable or that Pelco-D communication works.

## Fix Focus Areas
- arch/arm/boot/dts/hi3516a.dtsi[26-28]
- arch/arm/boot/dts/hi3516a-demb.dts[90-100]

## Recommended Fix
After verifying the board-specific UART and pinmux, boot the target hardware and test the resulting device node with the expected Pelco-D 9600 baud, 8N1 settings. Confirm pan, tilt, and zoom commands reach the secondary controller, and record the validation in the board documentation or test coverage.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

i2c0 = &i2c_bus0;
i2c1 = &i2c_bus1;
i2c2 = &i2c_bus2;
Expand Down