Repository navigation
ci: evict majestic's moving S3 tarball from the dl cache too - #109
Merged
Merged
Conversation
PR #105 added a "Refresh moving-ref package downloads" step that drops *-{HEAD,master,main,dist}.tar.gz before each build so buildroot re-fetches the current ref. That fixed the majestic-webui-dist.tar.gz staleness (the *-dist.tar.gz case), but it never matched majestic itself. majestic downloads from S3 as majestic.<family>.<variant>.master.tar.bz2 (majestic.mk) — a DOT separator, .tar.bz2, and an S3 host the old pattern deliberately spared as "content-addressed". But that S3 object is a moving `master` build, re-uploaded on every majestic CI run, with no .hash to force a refetch. So it stayed frozen in the monthly builder-dl cache while the webui refreshed — the exact desync that shipped a pre-x-groups majestic in a t31 lite image against the current webui, blanking the settings page with "No settings groups in schema." Broaden the eviction to a regex covering both -ref and .ref separators across gz/bz2/xz, so majestic.*.master.tar.bz2 and majestic-webui-dist.tar.gz are both dropped while semver/SHA-pinned tarballs keep their cache. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A t31 lite image (
t31_lite_xiaomi-mjsxj03hl-nor.tgz) shipped a stale majestic (master+2c8fc00, 2026-05-24) against a current webui, so the Majestic Settings page dies with "No settings groups in schema." Since webui #68 the settings tabs come only from majestic'sx-groupsschema manifest, which majestic emits only since 2026-06-12 (ab639ad3). The bundled majestic predated it.Root cause
PR #105's "Refresh moving-ref package downloads" step evicts
*-{HEAD,master,main,dist}.tar.gz. That covers the webui dist (majestic-webui-dist.tar.gz) but not majestic, which downloads from S3 as:— a dot separator,
.tar.bz2, on the S3 host the old pattern deliberately spared as "content-addressed". But that S3 object is a movingmasterbuild, re-uploaded on every majestic CI run, with no.hashto force a refetch. So it stayed frozen in the monthlybuilder-dlcache while the webui refreshed — the exact desync.(Verified: the live S3
majestic.t31.lite.master.tar.bz2is Last-Modified 2026-06-25 and does contain thex-groupsmanifest. So the bucket is fresh; only the build cache was stale. PR #105 fixed the prior polarity — stale webui — not this one.)Fix
Broaden the eviction to a regex covering both
-refand.refseparators across gz/bz2/xz:Evicts
majestic.*.master.tar.bz2andmajestic-webui-dist.tar.gz, while sparing semver/SHA-pinned tarballs (verified against samples, incl. the trickymastermind-2.0.tar.gz). Applied to bothbuild-one.ymlandmaster.yml.🤖 Generated with Claude Code