Repository navigation
Labels
reviewData and Metadata reviewData and Metadata reviewv1.5.1metadata created with version 1.5.1metadata created with version 1.5.1
Description
Issue description
I'm submitting an open dataset with a corresponding OEMetadata string for review.
The oedatamodel is a collection of multiple tables that are described in the resources. open_MODEX uses the oedatamodel to store input and output related data in the oedatamodel tables. The tables are used as a shared homogonous data source for the framework comparison.
Workflow checklist
- GitHub
- I have submitted this issue to have metadata and data review documented (Issue Review: open_MODEX-base_scenario #71 )
- Create a new review-branch and push OEMetadata to new branch (review/open_MODEX-base_scenario#71)
- OEP
- Upload data to the OEP in schema model_draft (see upload tutorial)
- Link URL of data in this issue (model_draft.project_nameofdata)
- Start a Review
- Start a pull request (PR) from review-branch to master
- Assign a reviewer and get in contact
- Reviewer section
- A reviewer starts working on the issue
- Review data license
- A reviewer finished working on this issue (and awarded a badge)
- Update metadata on table
- Data moved to its final schema
- Add OEP tags to table
- Merge PR and delete review-branch
- Document final links of metadata and data in issue description
- Close issue
Metadata and data for review
Here are the links to my data and metadata. Naming follows the pattern model_draft.project_nameofdata:
Metadata:
Data: https://openenergy-platform.org/dataedit/view/model_draft/project_nameofdata
Reviewed and published metadata and data
Final naming and location of the data and metadata after the review are as follows:
schema.tablename
Reacted by Ludwig Hülk
Metadata
Metadata
Assignees
Labels
reviewData and Metadata reviewData and Metadata reviewv1.5.1metadata created with version 1.5.1metadata created with version 1.5.1
Activity
Replace empty strings with null #71
Fix empty foreignKey section #71
Fix typo #71
christian-rli commentedon Oct 15, 2020
metadata can now be parsed by omi. content looks good. (When) will there be any data uploaded to the oep?
jh-RLI commentedon Oct 15, 2020
The upload is in progress. ATM we only have some incomplete data sets on the OEP. There are still some minor data-related issues.
christian-rli commentedon Nov 30, 2021
I noticed that the json covers several resources. However not all 4 tables that can be found when searching modex on the OEP are covered. Specifically oed_data is missing. At the same time, the three resources are listed in the metadata of each individual table, which I think is technically wrong. The tables might belong together, but the table description should reference only values of the table it describes. Contentwise everything looks ok, as far as i can tell.
christian-rli commentedon Nov 30, 2021
It's more complicated than I first thought, actually. There's a separate table for values, it appears. It is named oed_scalar and has resource descriptions in the metadata. However the table oed_data matches the resource description under
oed_concrete_scalar. This is a bit messed up. I could see the point of having several resource descriptions under one table, if all tables belong together, but this simply isn't accurate.christian-rli commentedon Nov 30, 2021
I cannot just download and reupload a new table, because i"m missing the column descriptions to create the new table (due to the same faulty metadata). I also have no time to write new column descriptions for the upload until tomorrow, because my train just arrived. I recommend showing the tables as is in the current directory. They have metadata that is largely correct. Fixing the structure is beyond what I can deliver today. Let me know if I can still help tomorrow forenoon @Ludee . Maybe @jh-RLI can either do a quick fix, or explain why this makes sense the way it is.
Ludee commentedon Nov 30, 2021
I guess that's the problem with the OEDatamodel. It has two formats and the metadata has to fit both.
Thanks for your help!
jh-RLI commentedon Nov 30, 2021
That's right, we used the oed-concrete format to create the metadata because that's the format a user should apply. The missing table only appears in the oed-normalization format. The normalization format is meant to be used on the database.
After creating the metadata, I didn't think to adjust the resources. I will adjust the resources to the normalization format. @Ludee @christian-rli
jh-RLI commentedon Nov 30, 2021
Should be fixed.
Review and update contex #71
Review and update sources #71
Move new files to correct path #71
Update metadata to v1.5.1 #71
Removed v1.4 files in old folder #71
Changed keywords #71
changed license names, if necessary and added contributor #71
Changed type in some fields #71