Repository navigation
Conversation
The timeout check stood alone, so the later else stored the reply as a normal cached result.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A RapidAPI timeout was stored as a normal cached result.
process_errormatches the timeout sentence, then a secondifstarts a new chain whoseelseclears the error and sets the cache flag. The timeout check is now the first branch of that chain.A timeout reply stays
API temporarily not working error...and is not cached. An unauthorized reply is still cached. A gateway failure is stillAPI not working error.... A normal payload is still cached with an empty error.Test plan
python -m unittest toolbench.inference.test_process_error(red on tip: the timeout error was''; green after: 4 tests pass)