Repository navigation
[P3][Review] Delete tracked developer virtual-environment launchers #106
Description
Review-only / approval gate
No implementation, PR merge, package publication or production mutation until the owner approves the full sprint plan.
Evidence
Reviewed main 31b8d80686495c5d6dcac0846d6e5a2c8d4bce8b.
git ls-tree -r main build-env returns 49 tracked entries, including bin/pip, bin/pytest, activation scripts, pyvenv.cfg and lib64 symlink. These are machine-specific environment artifacts, not SDK source. The local 34 MB directory is NOT all tracked; only the 49 entries are in scope.
Preferred smallest change
Delete tracked build-env launchers/config/symlink after checking no CI/package script depends on them; retain pyproject dependency declarations and clean-wheel smoke. Ignore recreated developer environments. No history rewrite or deletion of a developer's actual environment.
Acceptance / negative-path tests
Fresh dependency install and existing tests/build work without tracked environment files; sdist/wheel inventories exclude virtualenv artifacts; repository reference search proves no required consumer.
Risk and PR gate
P2, isolated correction; preserve public API compatibility.
One focused issue PR; independent adversarial review must challenge deletion safety, public compatibility, failure recovery and whether a smaller deletion suffices. Include red/green test evidence and packed/installable artifact proof for any published SDK/MCP change. Merge only in the approved priority order after reviewer objections are resolved. Do not publish a breaking change as a patch. If already fixed at execution time, record evidence and skip without a cosmetic PR.
Activity
karlwaldman commentedon Sep 5, 2026
Adversarial sprint admission — rank 35/70
Scheduled Monday, 2026-09-07 (America/New_York) in the approval-gated seven-night plan. Planning only; no implementation or merge yet.
Narrow outcome: Delete tracked developer virtualenv launchers.
Required issue → PR → independent review → ordered merge evidence
Risk window: Only isolated low/medium-risk changes. If admission discovers authentication/entitlement, destructive migration, live ingestion semantics or a breaking interface change, hold and move to the next approved Friday/Saturday window.
karlwaldman commentedon Sep 5, 2026
Coverage-audit revision — current sprint admission
Plan v2: oilpriceapi-api#8015 supersedes earlier scheduling comments. Rank 62/70; Thursday, 2026-09-10, America/New_York. Low/medium-risk only; reclassify to a Friday/Saturday slot if boundary/compatibility risk is higher.
Intended outcome: Delete tracked developer virtualenv launchers.
Coverage ledger: #8056. Inventory/pattern screening is complete; exhaustive semantic/runtime sign-off is not. Before implementation, review the complete affected file set and callers, revalidate against current main, supply the missing negative-path proof, and retain prior scope corrections. Prefer deletion, then simplification; correct behavior needs no PR.
No implementation is approved yet. After Karl approves: focused reversible PR → independent adversarial review → passing affected checks → merge in plan order → separately approved release/publish and artifact/customer-path verification. Maximum ten planned slots per night, not ten forced merges. If the dated window elapses before approval, re-anchor the calendar rather than backdate execution.