Repository navigation
Run Octopus Deploy Runbook: warn when the child runbook warns - #1708
Open
JeremyCamplin wants to merge 1 commit into
Open
JeremyCamplin wants to merge 1 commit into
JeremyCamplin wants to merge 1 commit into
Conversation
…with warnings Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Review this PR in Hyponome for a side-by-side diff of the step-template JSON and any embedded scripts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When using the Run Octopus Deploy Runbook step template and "Wait for finish" is enabled then the step treated State == Success as a clean pass, so a child runbook run that logged warnings showed the parent step as plain Success.
Updated the code to check the task's HasWarningsOrErrors flag and log a warning with a link to the child task so the step shows "Success with warning". Exit code and all other branches are unchanged.
Before
After
Side by side comparison of version 20 v version 21

Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$Metamust haveExportedAtandOctopusVersionupdated$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to it