Skip to content

Replace method=getXXX in the url query paramters with updated end points #27

Open

Description

@kan-fu

There are two ways to get a location tree

  1. Use /location/tree.
  2. Use /location?method=getTree.

The OpenAPI page uses the first style, while the client library uses the second one. They are handled equally in the backend, but it would be better to update the client library to follow the first style.

There are also other methods that need update like _OncRealTime.py, _OncArchive.py and _OncDelivery.py.

Activity

  1. Jacob-Stevens-Haas commented on Mar 10, 2024

    @Jacob-Stevens-Haas
    Collaborator

    Just to clarify, you don't mean removing methods like ONC.getLocations(), but to get them to call the Oceans 3 API differently?

  2. changed the title [-]Remove getXXX method[/-] [+]Replace getXXX method in the url query paramters with updated end points[/+] on Mar 11, 2024
  3. changed the title [-]Replace getXXX method in the url query paramters with updated end points[/-] [+]Replace method=getXXX in the url query paramters with updated end points[/+] on Mar 11, 2024
  4. kan-fu commented on Mar 11, 2024

    @kan-fu
    CollaboratorAuthor

    Just to clarify, you don't mean removing methods like ONC.getLocations(), but to get them to call the Oceans 3 API differently?

    You are right. Now I look at the title, it really seems that I want to delete the public methods 😅. I have updated the title to make it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions