Repository navigation
Sync partial moments, targets and dominance to R NNS 14.2 - #203
Open
gitRasheed wants to merge 6 commits into
Open
gitRasheed wants to merge 6 commits into
gitRasheed wants to merge 6 commits into
Conversation
OVVO-Financial
force-pushed
the
automation/r-cache-nns-14.2
branch
2 times, most recently
from
November 20, 2026 14:45
36332e2 to
8194bd3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm targeting the cache-refresh branch of #201 (
b184171c) and syncing Python to R NNS 14.2 at31291970.Nonetarget. With excess returns,lpm(1, None, [1, 2, 3, 10], True)returns 1.5. A nonfinite target raises before a bad degree.Decimal. A date counts days. NumPy datetimes and pandas timestamps keep their unit, so a target two seconds after the epoch giveslpm_ratioof 0.5 for degree 1 and data[0, 2, 4].pm_matrixaccepts"mean"and"means"for column means, including a one-element Series with index 0. It reads matrix targets by column. For four columns,[[1, 3], [2, 4]]supplies 1, 2, 3, 4.[0, inf]against[0, 1]it returns 1. Continuous FSD, SSD and TSD reject infinity.I kept Python's documented scalar broadcast in
pm_matrix. A target of 0 applies to every column. R NNS 14.0 and 14.2 both reject a single numeric target for multiple columns.I compared 4,438 native calls and 4,390 NumPy calls with live R and found zero regressions against #201. CI needs #202 to go green.