Repository navigation
nns_arma: lower prediction bound is LPM.VaR without abs() (book ch17, ch26) - #173
Closed
gitRasheed wants to merge 1 commit into
Closed
gitRasheed wants to merge 1 commit into
gitRasheed wants to merge 1 commit into
Conversation
This was referenced Nov 2, 2026
gitRasheed
force-pushed
the
rasheed/book-arma-pi-lower
branch
from
November 2, 2026 04:12
423941e to
e44704c
Compare
gitRasheed
force-pushed
the
rasheed/book-meboot-drift
branch
from
November 2, 2026 04:12
71c8967 to
41b0ec5
Compare
…r-bound)
Mirrors R's arma-pi-lower-bound branch (NNS.ARMA). The book gives the
interval as [LPM.VaR(alpha/2, d, X), UPM.VaR(alpha/2, d, X)] of the
bootstrapped forecast path (ch. 17 and 26). nns_arma took abs() of the
LPM.VaR value, so for a series whose bootstrapped forecasts go below 0
the lower quantile turned positive, landed above the forecast, and the
pmin with the estimates set the lower band equal to the forecast.
Positive series are unchanged. The NNS.MC bootstrap and the lin.resid
term stay as they were.
Before -> after, sin(t/2) * 5 - 10 + 0.5 cos(3t), t = 1..200, h = 6,
seasonal_factor=13, pred_int=0.95, seed 123:
estimates -10.74 -8.02 -5.79 -4.31 -4.79 -5.64
lower equal to the estimates
-> -11.34 -10.21 -9.28 -9.73 -6.59 -7.25
New NNS.ARMA.pred_int entry for the new test.
gitRasheed
force-pushed
the
rasheed/book-arma-pi-lower
branch
from
November 2, 2026 23:09
e44704c to
f8bca9c
Compare
Contributor
|
Incorporated through NNS R 14.0 integration #192, merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The book gives the interval as [LPM.VaR(alpha/2, d, X), UPM.VaR(alpha/2, d, X)] of the bootstrapped forecast path (ch17:273-276, ch26:552).
nns_armatook abs() of the LPM.VaR value, so for a series whose bootstrapped forecasts go below 0 the lower quantile turned positive, landed above the forecast, and the pmin with the estimates set the lower band equal to the forecast. We mirror OVVO-Financial/NNS#87, which makes R follow the book. That PR changes the method, so the R author may close it; if so, this slice should be dropped too.Stacked on #172; merge with a merge commit.
Changes
Positive series are unchanged. The NNS.MC bootstrap and the lin.resid term stay as they were. The book has neither lin.resid nor the pmin/pmax clamp, and we leave both to the R author.
Tests
A new parity test with its
NNS.ARMA.pred_intentry. The parity cache encodes R 13.3 plus the fixes in OVVO-Financial/NNS#73-#92. The nineNNS.VARstrict xfails stay until #174.Mirrors OVVO-Financial/NNS#87
Part of OVVO-Financial/NNS#71
Review
GPT-6.1 Sol reviewed this slice and found nothing.