Skip to content

Refresh two stale R cache entries and mark the live-R VAR examples - #162

Closed
gitRasheed wants to merge 3 commits into
rasheed/r-fixes-regression-stackfrom
rasheed/parity-cache-tests
Closed

gitRasheed wants to merge 3 commits into
rasheed/r-fixes-regression-stackfrom
rasheed/parity-cache-tests

Conversation

@gitRasheed

Copy link
Copy Markdown
Collaborator

Two test-only changes that finish the R-patch mirrors.

Stacked on #161; merge with a merge commit.

Changes

  • Re-record the NNS.caus causal-matrix ts.tau entry and one NNS.boost.numeric balance case. Both predated the tie, perfect-dependence and sign patches. The tests that read them pass with either value, but the shards now match the same R build as the rest of the cache.
  • Mark the two NNS.VAR practical examples xfail(strict=False). They compare with the locally installed R, and after the forecast-row fix they pass against the patched R and fail against unpatched R 13.3. CI has no R, so they skip there.

Tests

The parity cache encodes R 13.3 with the audit's R patches.

Review

GPT-6.1 Sol reviewed this slice and found nothing. Both refreshed entries match live patched R.

The two NNS.VAR practical examples compare with live installed R. After the
NNS.VAR fix (multivariate stage on the forecast rows) they pass against R
with the patch and fail against unpatched R 13.3, so mark them
xfail(strict=False) with that reason.
The NNS.caus causal-matrix ts.tau entry and one NNS.boost.numeric balance
case still predated the R degree-0 tie, NNS.copula perfect-dependence and
NNS.dep sign patches. The tests that read them
(test_causal_matrix_ts_tau_matches_r and
test_nns_boost_balance_multiclass_and_factor_structure) pass with either
value; re-record both from R 13.3 + the full patch series so the shards match
that R like the rest of the cache.
They point at notes that don't live in this repo.
@gitRasheed
gitRasheed force-pushed the rasheed/parity-cache-tests branch from 65f2970 to e5a1fe7 Compare November 2, 2026 23:09
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Incorporated through NNS R 14.0 integration #192, merged as bd19c3303222af46da79d8c97f258248eb5674d2. Verified exact head e5a1fe76b3e56e5b3bb791cc559fe737a2411261 is an ancestor of main; original commits and authorship are preserved. The integration includes the subsequent R14 compatibility corrections and passed the complete GitHub Python 3.11-3.14 matrix. This supersedes the separate landing, not the work or review history.

@github-actions github-actions Bot closed this Nov 7, 2026
@github-actions
github-actions Bot deleted the rasheed/parity-cache-tests branch November 7, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant