Repository navigation
[16.0] [FIX] queue_job: fix exception msg handling - #824
Merged
OCA-git-bot merged 1 commit intoSep 18, 2025
Merged
Conversation
Contributor
|
Hi @guewen, |
ThomasBinsfeld
force-pushed
the
16.0-fix_exception_name_to_args0-bwi
branch
from
September 16, 2025 09:23
e353b5a to
6341d0d
Compare
Contributor
Author
|
Reopening of the automatically closed PR #644 @simahawk Could we move forward with this one as the first PR seemed ready to be merged? |
benwillig
approved these changes
Sep 16, 2025
This was referenced Sep 16, 2025
AnizR
approved these changes
Sep 16, 2025
amh-mw
approved these changes
Sep 16, 2025
Contributor
Author
|
The modified file doesn't seem covered at all, we won't write its coverage in this PR. I suggest to merge as it. ping @guewen |
'name' attributes for odoo's exception has been deprecated and produces a warning message. This commit fixes the behavior
ThomasBinsfeld
force-pushed
the
16.0-fix_exception_name_to_args0-bwi
branch
from
September 17, 2025 08:17
6341d0d to
3a2f075
Compare
amh-mw
approved these changes
Sep 17, 2025
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 5b654ea. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use args[0] instead of name to get the exception message as the name attribute is deprecated
17.0 forward-port PR : #825
18.0 forward-port PR : #826